[LTP] [PATCH 1/1] checkpatch: Ignore warnings irrelevant in userspace

Petr Vorel pvorel@suse.cz
Wed Sep 21 13:22:22 CEST 2022


> Hi!
> > FYI the error is from fanotify.h (kind of lapi file for fanotify:
> <
> > #ifndef __kernel_fsid_t
> > typedef struct {
> > 	int	val[2];
> > } lapi_fsid_t;
> > #define __kernel_fsid_t lapi_fsid_t
> > #endif /* __kernel_fsid_t */

> > which we added in b8aebc835 ("fanotify: Fix missing __kernel_fsid_t definition")
> > "Instead of including <asm/posix_types.h> where it's defined we just
> > define the missing bit." (fix for musl).

> I'm aware of that, and while typedef is mostly wrong there are a few
> places where it's required.

> > But if you prefer to keep this check, I'm ok to merge it without it.

> > The long term solution could be to add variable to Makefile to pass extra
> > parameters, e.g.:
> > check_fanotify.h: CHECKPATCH_IGNORE += NEW_TYPEDEFS

> Case by case decisions like this for typedef sounds better to me.
+1 (TODO after the release).
Thanks for your time!

Kind regards,
Petr


More information about the ltp mailing list