[LTP] [PATCH 0/9] Fanotify tests for FAN_MARK_IGNORE

[Jan Kara]

Hi Amir!

On Mon 05-09-22 18:42:30, Amir Goldstein wrote:
> FAN_MARK_IGNORE feature was merge in v6.0-rc1.
> A man page draft was posted here [1].
> 
> Following are the tests for the new feature.
> 
> All new test cases are skipped on old kernels.
> 
> Note that fanotify10 will run ALL of its existing test cases
> in two variants:
> 1. Legacy FAN_MARK_IGNORED_MASK
> 2. New FAN_MARK_IGNORE
> 
> On old kernels, only the first variant of the test will run.
> 
> In addition to the new test variant it also has some new test cases
> that only run with new FAN_MARK_IGNORE variant.

Thanks for the tests! They look good to me although I have to admit my head
starts to spin with the number of combinations and variations in fanotify10
testcase so I'm not very confident some subtle bug could not slip in. But
hey, it's just tests and they are easy to fix if some breakage slips in. So
feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
 
> [1] https://lore.kernel.org/linux-man/20220904155113.2623371-1-amir73il@gmail.com/
> 
> Amir Goldstein (9):
>   syscalls/fanotify09: Add test cases for FAN_MARK_IGNORE
>   syscalls/fanotify14: Require FAN_REPORT_FID support for entire test
>   syscalls/fanotify14: Add test cases for FAN_MARK_IGNORE
>   syscalls/fanotify10: Avoid undesired event in test
>   syscalls/fanotify10: Add more verifications and debug info
>   syscalls/fanotify10: Use dedicated mark type for inode mark on parent
>   syscalls/fanotify10: Run tests with two ignore mask variants
>   syscalls/fanotify10: Test FAN_MARK_IGNORE with FAN_EVENT_ON_CHILD
>   syscalls/fanotify10: Test FAN_MARK_IGNORE with FAN_ONDIR
> 
>  testcases/kernel/syscalls/fanotify/fanotify.h |  19 ++
>  .../kernel/syscalls/fanotify/fanotify09.c     | 102 ++++++++--
>  .../kernel/syscalls/fanotify/fanotify10.c     | 186 ++++++++++++++----
>  .../kernel/syscalls/fanotify/fanotify14.c     |  42 +++-
>  4 files changed, 290 insertions(+), 59 deletions(-)
> 
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR