[LTP] [PATCH 0/9] Fanotify tests for FAN_MARK_IGNORE

[Amir Goldstein]

On Tue, Sep 6, 2022 at 6:38 PM Jan Kara <jack@suse.cz> wrote:
>
> Hi Amir!
>
> On Mon 05-09-22 18:42:30, Amir Goldstein wrote:
> > FAN_MARK_IGNORE feature was merge in v6.0-rc1.
> > A man page draft was posted here [1].
> >
> > Following are the tests for the new feature.
> >
> > All new test cases are skipped on old kernels.
> >
> > Note that fanotify10 will run ALL of its existing test cases
> > in two variants:
> > 1. Legacy FAN_MARK_IGNORED_MASK
> > 2. New FAN_MARK_IGNORE
> >
> > On old kernels, only the first variant of the test will run.
> >
> > In addition to the new test variant it also has some new test cases
> > that only run with new FAN_MARK_IGNORE variant.
>
> Thanks for the tests! They look good to me although I have to admit my head
> starts to spin with the number of combinations and variations in fanotify10
> testcase so I'm not very confident some subtle bug could not slip in. But

Yeh.. I can follow fanotify10 only on a good day ;)

The good thing about it is that after staring at it for long enough
I was able to extend it to provide test coverage for FAN_MARK_IGNORE
with relatively very little changes.

> hey, it's just tests and they are easy to fix if some breakage slips in. So
> feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks!
Amir.