[LTP] [PATCH v2 1/2] libswap: Add {SAFE_, }MAKE_MINIMAL_SWAPFILE() macros

Petr Vorel pvorel@suse.cz
Fri Apr 19 08:12:06 CEST 2024


> On Fri, Apr 19, 2024 at 9:50 AM Li Wang <liwang@redhat.com> wrote:

> > Hi Petr, Cyril,

> > The patchset generally looks good.

> > But I have a concern about the macro name "MINIMAL" word,
> > which misled people to think that is the minimal swapfile size we
> > can make on the system, but obviously it is not, we could even
> > create a smaller one, right?

> > Can we rename it with a better one?


> What about MAKE_DEFAULT_SWAPFILE, or MAKE_TEST_SWAPFILE?

I want to somehow express that it's a really small swap file
(although sure, not minimal). Sure, it can be "default" or "test",
but it does not say anything about the size.

Kind regards,
Petr


More information about the ltp mailing list