[LTP] [PATCH v2 1/2] libswap: Add {SAFE_, }MAKE_MINIMAL_SWAPFILE() macros

[Li Wang]

On Fri, Apr 19, 2024 at 2:12 PM Petr Vorel <pvorel@suse.cz> wrote:

> > On Fri, Apr 19, 2024 at 9:50 AM Li Wang <liwang@redhat.com> wrote:
>
> > > Hi Petr, Cyril,
>
> > > The patchset generally looks good.
>
> > > But I have a concern about the macro name "MINIMAL" word,
> > > which misled people to think that is the minimal swapfile size we
> > > can make on the system, but obviously it is not, we could even
> > > create a smaller one, right?
>
> > > Can we rename it with a better one?
>
>
> > What about MAKE_DEFAULT_SWAPFILE, or MAKE_TEST_SWAPFILE?
>
> I want to somehow express that it's a really small swap file
> (although sure, not minimal). Sure, it can be "default" or "test",
> but it does not say anything about the size.
>

Why do we have to emphasize the "small" swap file?
If we choose to use of "default" 1MB for LTP test but not
explicitly declarant in the name, that's okay, people can
check the defined value if they are interested.



>
> Kind regards,
> Petr
>
>

-- 
Regards,
Li Wang