[LTP] [PATCH v4] Add ioctl_ficlone04 test

Petr Vorel pvorel@suse.cz
Mon Jul 29 23:53:05 CEST 2024


> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
nit: ve usually put email into < > (e.g. <andrea.cervesato@suse.com>)
> > + */

...
> > +static void test_bad_fd(struct tst_fd *fd_src, struct tst_fd *fd_dst)
> > +{
> > +	if (fd_src->type == TST_FD_FILE && fd_src->type == fd_dst->type) {
> > +		tst_res(TCONF, "Skipping file: SUCCESS");

> Maybe just a TINFO here.

+1

Reviewed-by: Petr Vorel <pvorel@suse.cz>

FYI with 2 extra errno (ENOTTY, EFAULT) it would run also on 4.4 kernel (the
oldest still supported - SLE12-SP3) one with this result:

passed   360
failed   0
broken   0
skipped  121
warnings 0

Kind regards,
Petr


More information about the ltp mailing list