[LTP] [PATCH v4] Add ioctl_ficlone04 test

Cyril Hrubis chrubis@suse.cz
Tue Jul 30 09:42:45 CEST 2024


Hi!
> > > +static void test_bad_fd(struct tst_fd *fd_src, struct tst_fd *fd_dst)
> > > +{
> > > +	if (fd_src->type == TST_FD_FILE && fd_src->type == fd_dst->type) {
> > > +		tst_res(TCONF, "Skipping file: SUCCESS");
> 
> > Maybe just a TINFO here.
> 
> +1
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> FYI with 2 extra errno (ENOTTY, EFAULT) it would run also on 4.4 kernel (the
> oldest still supported - SLE12-SP3) one with this result:

I'm pretty sure EFAULT there is a kernel bug, ENOTTY sounds strange too.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list