[LTP] [PATCH v2 3/3] move_pages04: convert to new test API

Cyril Hrubis chrubis@suse.cz
Thu Oct 17 17:27:32 CEST 2024


Hi!
> +static struct tst_test test = {
> +	.test_all = run,
> +	.setup = setup,
> +	.max_runtime = 120,

This seems to be a bit excessive, generally tests that do run in less
than a second are not supposed to set this field.

Is there any reason for this to be there? If not I can remove this line
along with fixing the typo found by Jan and fix a bit of the formatting
for the documentation comment that is actually parsed by asciidoc before
applying the changes.

> +	.tags = (const struct tst_tag[]) {
> +		{"linux-git", "d899844e9c98"},
> +		{"linux-git", "7dff875c9436"},
> +		{}
> +	}
> +};
> -- 
> 2.46.1
> 

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list