[LTP] [PATCH v2 3/3] move_pages04: convert to new test API

David Hildenbrand david@redhat.com
Thu Oct 17 17:30:04 CEST 2024


On 17.10.24 17:27, Cyril Hrubis wrote:
> Hi!
>> +static struct tst_test test = {
>> +	.test_all = run,
>> +	.setup = setup,
>> +	.max_runtime = 120,
> 
> This seems to be a bit excessive, generally tests that do run in less
> than a second are not supposed to set this field.
> 
> Is there any reason for this to be there? 

No, copy and paste :)

> If not I can remove this line
> along with fixing the typo found by Jan and fix a bit of the formatting
> for the documentation comment that is actually parsed by asciidoc before
> applying the changes.


Perfect, thanks!


-- 
Cheers,

David / dhildenb



More information about the ltp mailing list