[LTP] [PATCH v3 5/8] syscalls/mknod05: Convert to new API

Cyril Hrubis chrubis@suse.cz
Fri Apr 25 17:30:49 CEST 2025


Hi!
> -struct stat buf;		/* struct. to hold stat(2) o/p contents */
> -struct passwd *user1;		/* struct. to hold getpwnam(3) o/p contents */
> +#define MODE_RWX 0777
> +#define MODE_SGID 2777
                     ^
		     There is 0 missing here.


And the test fail because of that because the mode is not interpreted as
octal number. I guess that this could be fixed before the push.

Other than this it looks fine. With that bit fixed:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list