[LTP] [PATCH v3 5/8] syscalls/mknod05: Convert to new API
Ricardo B. Marlière
rbm@suse.com
Fri Apr 25 18:26:29 CEST 2025
Hey hey!
On Fri Apr 25, 2025 at 12:30 PM -03, Cyril Hrubis wrote:
> Hi!
>> -struct stat buf; /* struct. to hold stat(2) o/p contents */
>> -struct passwd *user1; /* struct. to hold getpwnam(3) o/p contents */
>> +#define MODE_RWX 0777
>> +#define MODE_SGID 2777
> ^
> There is 0 missing here.
>
>
> And the test fail because of that because the mode is not interpreted as
> octal number. I guess that this could be fixed before the push.
>
> Other than this it looks fine. With that bit fixed:
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Thanks for the review and sorry for the mess on the modes. I'll send a
new revision!
More information about the ltp
mailing list