[LTP] Revert "tpci: unbind driver in test_assign_resources()"

linuxtestproject.agent@gmail.com linuxtestproject.agent@gmail.com
Tue Jul 14 12:49:59 CEST 2026


Hi Hongtao,

On Tue, 14 Jul 2026 17:06:32 +0800, Hongtao Zhang wrote:
> Revert "tpci: unbind driver in test_assign_resources()"

Two small commit-message issues below; the code itself looks fine.

> While the patch fixes a use-after-free in /proc/iomem by unbinding and
> rebinding the driver around PCI resource reassignment, this approach is
> too dangerous for a general test. Unbinding a driver from a critical device
> (e.g. a network or block controller) can instantly break SSH connectivity or
> cause filesystem corruption. Such side effects are unacceptable compared to
> the original issue.
> So need to revert that patch.

"So need to revert that patch." reads informally and is grammatically
incomplete. The motivation was already stated in the preceding sentences;
this closing line can be dropped entirely, or rewritten as "Revert the
patch."

Also, the body is missing the standard traceability line that git revert
adds: "This reverts commit <full-SHA>." Without it, bisect and git-log
searches cannot mechanically link this revert to the commit it undoes.
The subject quotes the original message, but the SHA makes the link
unambiguous. Please add it.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer


More information about the ltp mailing list