[LTP] Revert "tpci: unbind driver in test_assign_resources()"

[Yizhou Tang]

On Tue, Jul 14, 2026 at 6:50 PM <linuxtestproject.agent@gmail.com> wrote:
>
> Hi Hongtao,
>
> On Tue, 14 Jul 2026 17:06:32 +0800, Hongtao Zhang wrote:
> > Revert "tpci: unbind driver in test_assign_resources()"
>
> Two small commit-message issues below; the code itself looks fine.
>
> > While the patch fixes a use-after-free in /proc/iomem by unbinding and
> > rebinding the driver around PCI resource reassignment, this approach is
> > too dangerous for a general test. Unbinding a driver from a critical device
> > (e.g. a network or block controller) can instantly break SSH connectivity or
> > cause filesystem corruption. Such side effects are unacceptable compared to
> > the original issue.
> > So need to revert that patch.
>
> "So need to revert that patch." reads informally and is grammatically
> incomplete. The motivation was already stated in the preceding sentences;
> this closing line can be dropped entirely, or rewritten as "Revert the
> patch."
>
> Also, the body is missing the standard traceability line that git revert
> adds: "This reverts commit <full-SHA>." Without it, bisect and git-log
> searches cannot mechanically link this revert to the commit it undoes.
> The subject quotes the original message, but the SHA makes the link
> unambiguous. Please add it.
>
> Verdict - Needs revision

Hi,

We recently confirmed this commit does cause a flood of I/O errors on
the root filesystem in our testing, leaving the machine unusable until
reboot.

Given that, we'd appreciate the community helping to decide soon
whether the revert is warranted.

Best regards,
Yi

>
>
> ---
> Note:
>
> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.
>
> Regards,
> LTP AI Reviewer
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp