[LTP] lib: safe_file_ops: Add SAFE_FILE_READ_STR()
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Thu May 7 10:26:45 CEST 2026
Hi Cyril,
--- [PATCH 1/2] ---
On Thu, 7 May 2026, Cyril Hrubis wrote:
> lib: safe_file_ops: Add SAFE_FILE_READ_STR()
> + if (!fgets(buf, buf_size, f))
> + buf[0] = 0;
> +
> + size_t len = strlen(buf);
Move `size_t len` to the top of the function alongside `FILE *f`; mixed
declarations after executable statements violate kernel coding style.
--- [PATCH 2/2] ---
On Thu, 7 May 2026, Cyril Hrubis wrote:
> syscalls: newuname01: Fix fail on empty domainname
> Fixes: https://github.com/linux-test-project/ltp/issues/1304
`Fixes:` must reference a git commit hash in the form
`Fixes: <hash> ("<subject>")`. Use `Closes:` to reference GitHub issues.
---
Note:
Our agent completed the review of the patch.
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list