[LTP] lib: safe_file_ops: Add SAFE_FILE_READ_STR()
Andrea Cervesato
andrea.cervesato@suse.com
Thu May 7 10:29:29 CEST 2026
Hi,
> Hi Cyril,
>
> --- [PATCH 1/2] ---
>
> On Thu, 7 May 2026, Cyril Hrubis wrote:
> > lib: safe_file_ops: Add SAFE_FILE_READ_STR()
>
> > + if (!fgets(buf, buf_size, f))
> > + buf[0] = 0;
> > +
> > + size_t len = strlen(buf);
>
> Move `size_t len` to the top of the function alongside `FILE *f`; mixed
> declarations after executable statements violate kernel coding style.
I see this is happening again. I'm gonna add a rule for it.
>
> --- [PATCH 2/2] ---
>
> On Thu, 7 May 2026, Cyril Hrubis wrote:
> > syscalls: newuname01: Fix fail on empty domainname
>
> > Fixes: https://github.com/linux-test-project/ltp/issues/1304
>
> `Fixes:` must reference a git commit hash in the form
> `Fixes: <hash> ("<subject>")`. Use `Closes:` to reference GitHub issues.
>
This is actually correct. I will change the Fixes to Closes
before merge.
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
More information about the ltp
mailing list