[LTP] [PATCH] icmp_rate_limit01: Fix rate limit change on older kernels

[Martin Doucha]

On 5/6/26 11:12, Andrea Cervesato wrote:
> Hi Martin,
> 
>> @@ -257,6 +262,7 @@ static struct tst_test test = {
>>   	},
>>   	.save_restore = (const struct tst_path_val[]) {
>>   		{"/proc/sys/user/max_user_namespaces", "1024", TST_SR_SKIP},
>> +		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},
> 
> Shouldn't we use TST_SR_SKIP_MISSING here instead of TBROK?

Hi,
this .save_restore line references the icmp_msgs_burst sysfile in global 
network namespace which exists on all kernels since v3.18 if they have 
IPv4 support enabled. I guess we should add CONFIG_INET to 
.needs_kconfigs but otherwise the .save_restore is correct.

The access() check in setup(), on the other hand, searches for the same 
file in nested network namespaces where it may be missing on much more 
recent kernels.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic