[LTP] [PATCH] icmp_rate_limit01: Fix rate limit change on older kernels

[Cyril Hrubis]

Hi!
> >> @@ -257,6 +262,7 @@ static struct tst_test test = {
> >>   	},
> >>   	.save_restore = (const struct tst_path_val[]) {
> >>   		{"/proc/sys/user/max_user_namespaces", "1024", TST_SR_SKIP},
> >> +		{"/proc/sys/net/ipv4/icmp_msgs_burst", "50", TST_SR_TBROK},
> > 
> > Shouldn't we use TST_SR_SKIP_MISSING here instead of TBROK?
> 
> Hi,
> this .save_restore line references the icmp_msgs_burst sysfile in global 
> network namespace which exists on all kernels since v3.18 if they have 
> IPv4 support enabled. I guess we should add CONFIG_INET to 
> .needs_kconfigs but otherwise the .save_restore is correct.

Sounds good to me. Feel free to add my Reviewed-by: to a patch with
CONFIG_INET in the .needs_kconfigs

-- 
Cyril Hrubis
chrubis@suse.cz