[LTP] fsconfig04: Check FSCONFIG_SET_PATH
linuxtestproject.agent@gmail.com
linuxtestproject.agent@gmail.com
Wed Sep 16 15:28:35 CEST 2026
Hi Wei,
On Wed Sep 16 07:28:13 2026 +0000, Wei Gao wrote:
> fsconfig04: Check FSCONFIG_SET_PATH
> +static struct tst_test test = {
> + .test_all = run,
> + .setup = setup,
> + .cleanup = cleanup,
> + .needs_root = 1,
> + .needs_device = 1,
> + .needs_cmds = (struct tst_cmd []) {
> + {.cmd = "tune2fs"},
> + {}
> + },
> + .filesystems = (struct tst_fs []) {
> + {.type = "ext3"},
> + {.type = "ext4"},
> + {}
> + },
> +};
The test creates backing files "dev1_file" and "dev2_file" in setup(), but
.needs_tmpdir = 1 is missing. Set .needs_tmpdir = 1 so these files are created
in a temporary directory and cleaned up properly.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
More information about the ltp
mailing list