[LTP] fsconfig04: Check FSCONFIG_SET_PATH

[Wei Gao]

On Wed, Sep 16, 2026 at 01:28:35PM +0000, linuxtestproject.agent@gmail.com wrote:
> Hi Wei,
> 
> On Wed Sep 16 07:28:13 2026 +0000, Wei Gao wrote:
> > fsconfig04: Check FSCONFIG_SET_PATH
> 
> > +static struct tst_test test = {
> > +	.test_all = run,
> > +	.setup = setup,
> > +	.cleanup = cleanup,
> > +	.needs_root = 1,
> > +	.needs_device = 1,
> > +	.needs_cmds = (struct tst_cmd []) {
> > +		{.cmd = "tune2fs"},
> > +		{}
> > +	},
> > +	.filesystems = (struct tst_fs []) {
> > +		{.type = "ext3"},
> > +		{.type = "ext4"},
> > +		{}
> > +	},
> > +};
> 
> The test creates backing files "dev1_file" and "dev2_file" in setup(), but
> .needs_tmpdir = 1 is missing. Set .needs_tmpdir = 1 so these files are created
> in a temporary directory and cleaned up properly.
> 
> Verdict - Needs revision
.needs_tmpdir = 1 isn't required here because setting .needs_device = 1 already 
creates the temporary directory automatically in the LTP framework.
> 
> ---
> Note:
> 
> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.
> 
> Regards,
> LTP AI Reviewer