[LTP] [PATCH 1/1] ipneigh01: Replace TCONF error message with TINFO

Anton Smorodskyi asmorodskyi@suse.de
Mon May 7 13:13:30 CEST 2018

Hi Alexey

This is my first attempt to contribute to LTP project. Disadvantage of 
this is the fact that I can ask some obvious for you question ( hope you 
will forgive me that) , but advantage that I have a fresh look so I can 
point out to something that is wrong but you just get used too.

First of all let's clarify something not related to this PR directly :

>> And why it is more appropriate? TCONF is not an error message.
In LTP documentation TCONF defined as - "The test case was not 
appropriate for the current hardware or software configuration". So I 
would not call it error too but I would say that it is some flavor of 
"SKIPPED" state.
Where you want to say "this test case can't run currently so I can't say 
if it is passed or failed"

Second thing which needs to be taken in consideration  I clarified with 
Petr Vorel in conversation outside this ML - test counter changed only 
on TPASS or TFAIL. This lead us to really confusing log output :

    ipneigh01 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
    ipneigh01 1 TINFO: set local addr
    ipneigh01 1 TINFO: set local addr fd00:1:1:1::2/64
    ipneigh01 1 TINFO: initialize 'rhost' 'ltp_ns_veth1' interface
    ipneigh01 1 TINFO: set remote addr
    ipneigh01 1 TINFO: set remote addr fd00:1:1:1::1/64
    ipneigh01 1 TINFO: Network config (local -- remote):
    ipneigh01 1 TINFO: ltp_ns_veth2 -- ltp_ns_veth1
    ipneigh01 1 TINFO: --
    ipneigh01 1 TINFO: fd00:1:1:1::2/64 -- fd00:1:1:1::1/64
    ipneigh01 1 TCONF: 'arp cmd doesn't support IPv6, skipping test-case
    ipneigh01 1 TINFO: Stress auto-creation of NDISC cache entry
    ipneigh01 1 TINFO: by pinging 'fd00:1:1:1::1' and deleting entry again
    ipneigh01 1 TINFO: with 'ip neigh del fd00:1:1:1::1 dev ltp_ns_veth2'
    ipneigh01 1 TPASS: verified adding/removing of NDISC cache entry

Please correct me if I missing something but I read this like "ok we 
can't run this test case because arp cmd doesn't support IPv6 , ah but 
wait test case is passed ".

After all discussions around that patch and all info which I gain I can 
agree that changing TCONF with TINFO was bad idea , but if we will just 
"fix" issue by changing TST_TOTAL value to 1 ( if I correctly understand 
your suggestion )
this will not remove this confusion.

Only valid fix which I see is change behavior of LTP to change test case 
counter after TCONF which makes total sense for me , but most probably I 
missing something and you had some reasons to not changing counter on 
TCONF messages. Can you please elaborate them ?

Anton Smorodskyi <asmorodskyi@suse.com>
QA Engineer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755;  https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180507/c51ccb69/attachment.html>

More information about the ltp mailing list